Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Chore: (Marked.js) 'getHighlighterCore' is deprecated. Use createHighlighterCore or getSingletonHighlighterCore instead. #137

Merged
merged 3 commits into from
Jul 1, 2024
Merged

♻️ Chore: (Marked.js) 'getHighlighterCore' is deprecated. Use createHighlighterCore or getSingletonHighlighterCore instead. #137

merged 3 commits into from
Jul 1, 2024

Conversation

create-issue-branch[bot]
Copy link
Contributor

Original issue description

image

'getHighlighterCore' is deprecated. Use createHighlighterCore or getSingletonHighlighterCore instead.

We use this for the Shiki Syntax highlighter that is part of the Marked.js Markdown parser, Shiki has deprecated getHighlighterCore in favor for their new createHighlighterCore or getSingletonHighlighterCore.

My plan is to change to the createHighlighterCore as it is most similar to the current setup that we are running.

Marked.ts file that needs changing (Ln 122 - Ln 126)

closes #128

@create-issue-branch create-issue-branch bot changed the title Chore: (Marked.js) 'getHighlighterCore' is deprecated. Use createHighlighterCore or getSingletonHighlighterCore instead. ♻️ Chore: (Marked.js) 'getHighlighterCore' is deprecated. Use createHighlighterCore or getSingletonHighlighterCore instead. Jul 1, 2024
@Adammatthiesen Adammatthiesen marked this pull request as ready for review July 1, 2024 16:49
@Adammatthiesen Adammatthiesen requested a review from a team July 1, 2024 16:53
dreyfus92
dreyfus92 approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@Adammatthiesen Adammatthiesen mentioned this pull request Jul 1, 2024
Closed
17 tasks
jdtjenkins
jdtjenkins approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@jdtjenkins jdtjenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep looks good

@Adammatthiesen
Copy link
Member

!coauthor

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2024 

Co-authored-by: Adam Matthiesen <30383579+Adammatthiesen@users.noreply.github.com>
Co-authored-by: Jacob Jenkins <7649031+jdtjenkins@users.noreply.github.com>
Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>

@Adammatthiesen Adammatthiesen merged commit e13e77e into main Jul 1, 2024
2 checks passed
@Adammatthiesen Adammatthiesen deleted the issue-0128 branch July 1, 2024 17:27
@create-issue-branch create-issue-branch bot mentioned this pull request Jul 23, 2024
Merged
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdtjenkins jdtjenkins jdtjenkins approved these changes

@dreyfus92 dreyfus92 dreyfus92 approved these changes

Assignees

@Adammatthiesen Adammatthiesen

Labels
chore fix
Projects
None yet
Milestone
No milestone
3 participants
@Adammatthiesen @jdtjenkins @dreyfus92