unittest in CircleCI in parallel #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgvishnuram
approved these changes
Feb 7, 2024
|
Much needed optimization |
rishkarajgi
approved these changes
Feb 7, 2024
|
@danielhoherd Can we spin up an issue ticket for this please. Will track this as a tech debt item |
|
@rishkarajgi turns out there already is one! https://github.com/astronomer/issues/issues/5199 |
danielhoherd
added a commit
that referenced
this pull request
Feb 7, 2024
danielhoherd
added a commit
that referenced
this pull request
Feb 7, 2024
|
I merged this to master and then cherry-picked into 1.8 and 1.9, and merged master into 1.10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds parallel unit testing in CircleCI, which is something we do in astronomer/astronomer. The unittest step takes 18m20s on average as it is. https://app.circleci.com/insights/github/astronomer/airflow-chart/workflows/install-airflow-chart/jobs?branch=master&reporting-window=last-90-days This PR cuts that 18m20s down to about 4m20s https://app.circleci.com/pipelines/github/astronomer/airflow-chart/2126/workflows/ff7ab1a7-3067-4a78-9ecf-e4ab7d7701d3/jobs/23388
Related Issues
Testing
No QA testing is needed. These changes are only CircleCI related.
Merging
Merge everywhere.