update dag-deploy permissions for rollback feature #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The dag-deploy component is being updated to support rollbacks. In that change set, we moved from events to configmaps for communicating between server and clients. This change set updates the permissions used by dag-server and dag-downloader with the changes and permissions needed on configmaps, and removes events.
We should merge #495 first because this PR includes changes from that branch that we don't want to include as part of this change set.
Related Issues
Testing
Unit tests were added to this change set. We'll need to manually test dag-deploys to make sure they are functioning. QA will know if this is broken if they see any configmap permission errors.
Merging
Merge only into whatever airflow-chart version will go into release-0.35 since this is related to the rollback feature, which is for 0.35.