add authsidecar security context support for dag server #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgvishnuram
added a commit
that referenced
this pull request
May 26, 2024
* add authsidecar security context support for dag server * add test cases * update test cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds supports for dag server auth sidecar with securityContext support
Note: for webserver and celery we pass securityContext from code reading from global astronomer authsidecar values, for dag-server authsidecar we have a slightly different approach to handle them with the chart itself
Related Issues
https://github.com/astronomer/issues/issues/6325
https://github.com/astronomer/issues/issues/6328
Testing
QA should see globally passed valid securityContext to dag server auth sidecar container
Merging
cherry-pick to release-1.10 and other upcomming releases