Move fivetran sync provider code to this repo #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @phanikumv can please take a look to this PR? |
Lee-W
reviewed
Jul 4, 2023
phanikumv
reviewed
Jul 4, 2023
utkarsharma2
reviewed
Jul 4, 2023
| fivetran_operator = FivetranOperator( | ||
| task_id="fivetran-operator", | ||
| fivetran_conn_id="fivetran_default", | ||
| connector_id="{{ var.value.connector_id }}", |
There was a problem hiding this comment.
Are we testing dags in CI? or AstroCloud?
There was a problem hiding this comment.
manual testing is done on Astro cloud
There was a problem hiding this comment.
yes, we have manual testing. I have attached the dagrun screenshot
sunank200
reviewed
Jul 4, 2023
pankajkoti
reviewed
Jul 4, 2023
This was referenced Jul 10, 2023
|
created a follow-up GH issue for depreciation and merging both operator/sensor #35 |
pankajastro
force-pushed
the
remove_fivetran_deps
branch
from
d086d3a
to
aeed44a
Compare
sunank200
reviewed
Jul 11, 2023
Co-authored-by: Ankit Chaurasia <8670962+sunank200@users.noreply.github.com>
sunank200
approved these changes
Jul 11, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #30
Move code from https://github.com/fivetran/airflow-provider-fivetran to this repo
Example DAG
