Update deprecated map_metric import in custom #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cdkini Is this a breaking change? Want to know if the next release will have to have a major version bump. Or is it just going to rely on GX >= 16? In the latter case, https://github.com/astronomer/airflow-provider-great-expectations/blob/main/setup.cfg#L37 should be updated as well. |
|
@cdkini could you please comment on the above? Would love to merge this today |
|
@denimalpaca apologies for the delay! No additional changes are necessary - |
denimalpaca
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there! I'm a core dev on the GX team and am currently working through cleaning up some deprecated code as part of our v16 release.
One of these items happens to be the
great_expectations.expectations.metrics.map_metricimport - this has been renamed togreat_expectations.expectations.metrics.map_metric_provideras of v0.13 and per our policy of removing deprecated code after two minor versions, I'm hoping to delete as much old code as possible.I've proposed the necessary change below. Thanks!