Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constrain versions for Providers during docker build for 2.0.0 #212

Merged
merged 2 commits into from Feb 11, 2021

Conversation

kaxil
Copy link
Contributor

@kaxil kaxil commented Feb 9, 2021

Since we are planning to cut 2.0.0-3 we should release the same set of Providers except for few exceptions:

apache-airflow-providers-elasticsearch==1.0.1 -- contains our logging fix
apache-airflow-providers-cncf-kubernetes==1.0.1 -- contains a bug fix for K8s Operator
apache-airflow-providers-microsoft-azure==1.1.0 -- Will allow installing snowflake provider (includes apache/airflow#12188)

Since these constraint sare only used in docker build time and not included in Dockerfile users are free to upgrade to a major version for providers like google. This is the main different between this constraints file vs pip-constraints.txt.

Without this change, new versions of providers would be installed (even the major ones)

@ernest-kr
Copy link
Contributor

@kaxil There is a problem if users try to upgrade the azure provider from 1.0.0 to 1.1.0.

apache/airflow#12188

This workaround will fix . Shall we include this ?

USER root
RUN pip uninstall azure-storage --yes
RUN pip install azure-storage-blob
USER astro

Since we are planning to cut 2.0.0-3 we should release the same set of Providers except for few exceptions:

apache-airflow-providers-elasticsearch==1.0.1 -- contains our logging fix
apache-airflow-providers-cncf-kubernetes==1.0.1 -- contains a bug fix for K8s Operator
apache-airflow-providers-microsoft-azure==1.1.0 -- Will allow installing snowflake provider (includes apache/airflow#12188)

Since this constraints are only used in docker build time and not included in Dockerfile users are free to upgrade to a major version for providers like google.
@kaxil
Copy link
Contributor Author

kaxil commented Feb 9, 2021

@kaxil There is a problem if users try to upgrade the azure provider from 1.0.0 to 1.1.0.

apache/airflow#12188

This workaround will fix . Shall we include this ?

USER root
RUN pip uninstall azure-storage --yes
RUN pip install azure-storage-blob
USER astro

@ernest-kr the PR already fixes that, we don't use the old azure provider, check my PR Description 😊

@kaxil
Copy link
Contributor Author

kaxil commented Feb 10, 2021

ping @ashb @ernest-kr

Copy link
Contributor

@ashb ashb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I'm not sure. L

@kaxil kaxil merged commit 5a4eb39 into master Feb 11, 2021
@kaxil kaxil deleted the pin-provider-2.0.0 branch February 11, 2021 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants