Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): hide feedback when error occurs #102

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

Lee-W
Copy link
Collaborator

@Lee-W Lee-W commented Nov 9, 2023

closes: #99

@Lee-W Lee-W force-pushed the donot-ask-for-feedback-when-error branch from d1ea50f to 0786d81 Compare November 9, 2023 09:24
@Lee-W Lee-W changed the title Donot ask for feedback when error feat(ui): hide feedback when error occurs Nov 9, 2023
Copy link

cloudflare-pages bot commented Nov 9, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0786d81
Status: ✅  Deploy successful!
Preview URL: https://a6de5943.ask-astro.pages.dev
Branch Preview URL: https://donot-ask-for-feedback-when.ask-astro.pages.dev

View logs

Copy link
Collaborator

@sunank200 sunank200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lee-W how did you test this?

@sunank200 sunank200 merged commit cbef56a into main Nov 14, 2023
7 checks passed
@sunank200 sunank200 deleted the donot-ask-for-feedback-when-error branch November 14, 2023 07:06
@Lee-W
Copy link
Collaborator Author

Lee-W commented Nov 16, 2023

LGTM

@Lee-W how did you test this?

Change the backend code to forcefully trigger response with status_code 500

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't ask for feedback when Ask Astro hits an error
2 participants