Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(circleci): setup deploy-docs job #130

Merged
merged 2 commits into from
Nov 22, 2023
Merged

ci(circleci): setup deploy-docs job #130

merged 2 commits into from
Nov 22, 2023

Conversation

Lee-W
Copy link
Collaborator

@Lee-W Lee-W commented Nov 16, 2023

Close: #122

I think the last step we need is

Now, we need to upload the public key to GitHub so that it knows to trust a connection from CircleCI initiated with our private key. We head to https://github.com/jklukas/docs-on-gh-pages/settings/keys > Add Deploy Key, make the title of it “CircleCI write key” and paste in the contents of docs_deploy_key_rsa.pub. If you haven’t already deleted the private key, be extra careful you’re not accidentally copying from docs_deploy_key_rsa!

which might need @sunank200 's help on setting this up. (Scheduled messages with info and instructions for this setup on Slack)

ref: https://circleci.com/blog/deploying-documentation-to-github-pages-with-continuous-integration/

Copy link

cloudflare-pages bot commented Nov 16, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7ca054b
Status: ✅  Deploy successful!
Preview URL: https://fc479ce5.ask-astro.pages.dev
Branch Preview URL: https://setup-gh-pages-deploy.ask-astro.pages.dev

View logs

@Lee-W Lee-W force-pushed the setup-gh-pages-deploy branch 5 times, most recently from 2d432f0 to bd2b6e5 Compare November 16, 2023 03:16
@Lee-W Lee-W marked this pull request as ready for review November 16, 2023 03:20
@Lee-W
Copy link
Collaborator Author

Lee-W commented Nov 17, 2023

https://astronomer.github.io/ask-astro/

it's here

Copy link
Collaborator

@sunank200 sunank200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

But let's make sure that airflow docs are visible first as part of this PR: #131 before merging this.

@sunank200
Copy link
Collaborator

Screenshot 2023-11-20 at 6 53 45 PM This is still not visible correctly @Lee-W ?

@Lee-W
Copy link
Collaborator Author

Lee-W commented Nov 20, 2023

Screenshot 2023-11-20 at 6 53 45 PM This is still not visible correctly @Lee-W ?

This branch only do the github actions part. not the documentation update. that's done in #131

@Lee-W
Copy link
Collaborator Author

Lee-W commented Nov 20, 2023

just rebased. once this is merged, the doc will be updated

@Lee-W Lee-W merged commit d522907 into main Nov 22, 2023
8 checks passed
@Lee-W Lee-W deleted the setup-gh-pages-deploy branch November 22, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add GitHub pages
2 participants