Ingest astronomer-provider/astro-sdk html docs #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
155e23d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://35e23cfe.ask-astro.pages.dev |
| Branch Preview URL: | https://ingest-astro-sdk-docs.ask-astro.pages.dev |
pankajastro
changed the title
pankajastro
force-pushed
the
ingest_astro_sdk_docs
branch
from
5725c12
to
8477432
Compare
pankajastro
changed the title
sunank200
requested changes
Dec 11, 2023
There was a problem hiding this comment.
@pankajastro can you add this change to bulk load DAG as well?
pankajastro
force-pushed
the
ingest_astro_sdk_docs
branch
from
340da2c
to
0abd177
Compare
pankajastro
force-pushed
the
ingest_astro_sdk_docs
branch
from
0e52e34
to
9ff6db4
Compare
sunank200
requested changes
Dec 13, 2023
| urls = extract_internal_url(base_url, exclude_docs) | ||
| version_pattern = re.compile(r"[0-9]+(\.[0-9]+){1,2}") | ||
|
|
||
| new_urls = [url for url in urls if not version_pattern.search(url)] |
There was a problem hiding this comment.
This should just pick the latest one.
There was a problem hiding this comment.
change to match "stable"
sunank200
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #166
closes: #165