Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a cutoff date for GitHub issue #229

Merged
merged 4 commits into from
Dec 26, 2023
Merged

Add a cutoff date for GitHub issue #229

merged 4 commits into from
Dec 26, 2023

Conversation

pankajastro
Copy link
Collaborator

@pankajastro pankajastro commented Dec 22, 2023

closes: #227

Recently, we started getting zombie job and I feel this because of lot of data on worker

Recently, we started getting zombie job and I feel this because of lot of data on worker
@pankajastro pankajastro marked this pull request as ready for review December 22, 2023 07:08
@@ -203,7 +204,7 @@ def extract_github_issues(repo_base: str, github_conn_id: str) -> pd.DataFrame:
gh_hook = GithubHook(github_conn_id)

repo = gh_hook.client.get_repo(repo_base)
issues = repo.get_issues(state="all")
issues = repo.get_issues(state="all", since=datetime(2022, 1, 1))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This date should be environment variable or something that can be configured from UI

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated PTAL

Copy link
Collaborator

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could make the cuteoff date configurable, but not a blocker to this PR

Copy link

cloudflare-pages bot commented Dec 26, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: cce6c49
Status: ✅  Deploy successful!
Preview URL: https://ec4ec239.ask-astro.pages.dev
Branch Preview URL: https://fix-dag.ask-astro.pages.dev

View logs

@pankajastro pankajastro merged commit d70c0f1 into main Dec 26, 2023
7 checks passed
@pankajastro pankajastro deleted the fix_dag branch December 26, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in extract github issues
3 participants