Use sanic-limiter to throttle api requests

[pankajkoti]

Throttles API requests based on user's IP address.
With this PR, at the moment, we are only throttling /requests endpoint.

closes: #230

[cloudflare-pages]

Deploying with    Cloudflare Pages

Latest commit:	9438371
Status:	✅  Deploy successful!
Preview URL:	https://9855bce3.ask-astro.pages.dev
Branch Preview URL:	https://230-throttle-api.ask-astro.pages.dev

View logs

[pankajkoti]

Throttling in action

[jlaneve]

I don’t know if these rates are permissive enough - the UI polls the API every few seconds

what’s the intent behind this? can we gate just the “submit prompt” endpoint?

[pankajkoti]

I don’t know if these rates are permissive enough - the UI polls the API every few seconds

what’s the intent behind this? can we gate just the “submit prompt” endpoint?

yes, we can very well do route based throttling. I thought the UI would not poll more than a certain number of times per minute for the requests/request_id endpoint, no? Also those limits can be configured via environment variables, I just kept some default values for those.

The context for the intent is here though: https://astronomer.slack.com/archives/C05QJA9LTR9/p1703159886303619 (this has been linked in the issue #230 description)

[pankajastro]

LGTM. This will have no impact on the Slack path since it does not make rest API calls, right?
https://github.com/astronomer/ask-astro/blob/main/api/ask_astro/slack/controllers/mention.py#L119

[pankajkoti]

LGTM. This will have no impact on the Slack path since it does not make rest API calls, right? https://github.com/astronomer/ask-astro/blob/main/api/ask_astro/slack/controllers/mention.py#L119

yes, correct it won't impact Slack calls. However, Slack could impose rate limits by itself based on the limits specified here https://api.slack.com/apis/rate-limits

[pankajastro]

LGTM

[pankajkoti]

Result after throttled requests endpoint post applying review suggestions.