Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link Astro docs to the webpage not github #238

Merged
merged 6 commits into from
Jan 4, 2024
Merged

Link Astro docs to the webpage not github #238

merged 6 commits into from
Jan 4, 2024

Conversation

sunank200
Copy link
Collaborator

@sunank200 sunank200 commented Dec 28, 2023 •
edited

  • Create a separate DAG to scrap astronomer docs.
  • Link astro docs to the webpage, not GitHub.
  • Change all existing DAGs.
  • Tested the ingestion here

closes: #129

@sunank200 sunank200 mentioned this pull request Dec 28, 2023
Closed
@cloudflare-pages Cloudflare Pages
Copy link

cloudflare-pages bot commented Dec 28, 2023 •
edited

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3ec4f2c
Status: ✅  Deploy successful!
Preview URL: https://190a0bb9.ask-astro.pages.dev
Branch Preview URL: https://astro-docs.ask-astro.pages.dev

View logs

@sunank200 sunank200 mentioned this pull request Dec 28, 2023
Closed
11 tasks
@sunank200 sunank200 changed the title Astro docs links to the webpage not github Link Astro docs to the webpage not github Dec 28, 2023
@vatsrahul1001
Copy link
Collaborator

Verified this in issue, LGTM

sunank200 and others added 2 commits January 3, 2024 17:03
@sunank200 sunank200 requested a review from Lee-W January 3, 2024 11:20
@sunank200 sunank200 merged commit 7362c54 into main Jan 4, 2024
8 checks passed
@sunank200 sunank200 deleted the astro_docs branch January 4, 2024 11:38
@TJaniF TJaniF mentioned this pull request Jan 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lee-W Lee-W Lee-W approved these changes

@pankajastro pankajastro Awaiting requested review from pankajastro pankajastro is a code owner

@pankajkoti pankajkoti Awaiting requested review from pankajkoti

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Astro docs should link to the webpage not github
5 participants
@sunank200 @vatsrahul1001 @Lee-W @pankajkoti @pankajastro