Improve readibility of list results #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pankajkoti
requested review from
Lee-W,
pankajastro and
sunank200
as code owners
Deploying with
|
| Latest commit: |
4b42453
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a3384d00.ask-astro.pages.dev |
| Branch Preview URL: | https://215-list-results-readibility.ask-astro.pages.dev |
|
Before After |
pankajkoti
force-pushed
the
215-list-results-readibility
branch
from
8b8a93b
to
ee6e5f2
Compare
The UI renders the response from ask-astro pipeline as a markdown. For list items, the UI is able to render the list properly when the list items are separated by `\n\n` in the backend response, however when the list items are separated by a single `\n`, it fails to render them correctly. It's weird how OpenAI completion response at times adds a double new line chars and at times adds a single new line char to separate list items. However, I am adding a transform to convert single new line chars to double and when the response already contains two new line chars, not adding any extra new line char. closes: #215
pankajkoti
force-pushed
the
215-list-results-readibility
branch
from
ee6e5f2
to
4b42453
Compare
This was referenced Jan 16, 2024
sunank200
added a commit
that referenced
this pull request
Jan 16, 2024
After asking questions in ask.astronomer.io the UI broke after this [PR](#240) as there is no check for `"response"` key in the returned dictionary [here](https://github.com/astronomer/ask-astro/blob/main/api/ask_astro/rest/controllers/get_request.py#L46) Added the check for the "response" key in the dictionary in the API. Tested with the following screenshot: <img width="1719" alt="Screenshot 2024-01-16 at 4 24 58 PM" src="https://github.com/astronomer/ask-astro/assets/8670962/3a06a613-2ff4-4d3a-a63d-c1ef2627fb03"> close: #266
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UI renders the response from ask-astro pipeline as a markdown.
For list items, the UI is able to render the list properly when the
list items are separated by
\n\nin the backend response, howeverwhen the list items are separated by a single
\n, it fails to renderthem correctly. It's weird how OpenAI completion response at times
adds a double new line chars and at times adds a single new line
char to separate list items. However, I am adding a transform to
convert single new line chars to double and when the response
already contains two new line chars, not adding any extra new line char.
closes: #215