-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change MultiQuery Prompt, Add Hybrid Search (BM25 + Embedding), Cohere Reranker & LLM Chain Filter #247
Conversation
Deploying with
|
Latest commit: |
992beb5
|
Status: | ✅ Deploy successful! |
Preview URL: | https://1fdf887b.ask-astro.pages.dev |
Branch Preview URL: | https://hybrid-search-reword-and-rer.ask-astro.pages.dev |
from langchain_core.prompts import PromptTemplate | ||
|
||
|
||
class CustomBooleanOutputParser(BaseOutputParser[bool]): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: this is a changed implementation from langchain. The original code looked like this https://github.com/langchain-ai/langchain/blob/master/libs/langchain/langchain/output_parsers/boolean.py
I implemented this parser because of an unfixed issue on LangChain here langchain-ai/langchain#11408 where their check on the Yes/NO is way too strict and throws unwanted errors during runtime.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vatsrahul1001 did you get a chance to test this? which weaviate index should be used @davidgxue ?
@sunank200 no I have not tested this end to end, Also as per Steven's commentcan you readthedocs stuff is withdrawn? |
@vatsrahul1001 yes. The readthedocs from astro-sdk is not there in database now |
Ok, I will test it tomorrow then |
Yes, I checked with Rahul and he will get onto checking the response quality today! |
@davidgxue, I have completed the testing and observed an overall improvement in the quality of responses. Even for basic Astro SDK questions, responses have improved, even without the Astro SDK docs. However, for questions in Ask Astro that were specifically designed from the docs, the responses have degraded, which is as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Technical Changes
Notes