Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return the source documents in same order for slackbot as per the response in the UI #256

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

sunank200
Copy link
Collaborator

@sunank200 sunank200 commented Jan 10, 2024

  • Add a fix so that the Slackbot should receive the source documents in the same order as they appear in the UI.

closes: #250

Tested it here:
Screenshot 2024-01-10 at 9 47 42 PM
Screenshot 2024-01-10 at 9 48 07 PM

Slack request: https://ankit-test-group.slack.com/archives/C061F4LR4KT/p1704903223475919
Web UI request: https://f9c33f8b.ask-astro.pages.dev/requests/48c82d1e-afd1-11ee-a80f-42004e494300

Copy link

cloudflare-pages bot commented Jan 10, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: cec44f0
Status: ✅  Deploy successful!
Preview URL: https://c826d010.ask-astro.pages.dev
Branch Preview URL: https://fix-source-order.ask-astro.pages.dev

View logs

@sunank200 sunank200 marked this pull request as ready for review January 10, 2024 16:19
Copy link
Contributor

@pankajkoti pankajkoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title and description looks a bit off. I think the requirement is that the ordering needs to be consistent, here it could mean that we're removing the ordering.

api/ask_astro/slack/controllers/mention.py Show resolved Hide resolved
Copy link
Collaborator

@davidgxue davidgxue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. For the comment about duplicates, up to you whether you want to check for duplicates. I think either way works!

@pankajkoti
Copy link
Contributor

pankajkoti commented Jan 11, 2024

The PR title and description needs to be corrected however IMO, the current title means opposite to what is intended. #256 (review)

@sunank200 sunank200 changed the title Remove ordering from sources links in slack Return the source documents in same order for slackbot as per the response in the UI Jan 11, 2024
@sunank200
Copy link
Collaborator Author

The PR title and description needs to be corrected however IMO, the current title means opposite to what is intended. #256 (review)

Changed it Pankaj

@sunank200 sunank200 merged commit 3f1e789 into main Jan 11, 2024
8 checks passed
@sunank200 sunank200 deleted the fix_source_order branch January 11, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slack bot returning source documents in different order from backend/website/LangSmith
4 participants