Fix MultiQueryRetriever Prompt Rewording Inconsistent Formatting Error #276
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
LineListOutputParser
used in LangChain'sMultiQueryRetriever
not cleaning enough edge cases such as empty lines generated from LLM between reworded prompt lines causing an error thrown downstream (the empty line, along with other 2 reworded prompts are individually sent downstream to be used for vector db documents retrieval but an empty string will error out during this phase).Technical Changes
CustomLineListOutputParser
, a modified, less error prone implementation of the LineListOutputParser from LangChain. This CustomLineListOutputParser will get rid of lines that are empty lines and also limits the max number of lines or queries the multi-query retriever can generate through rewording.output_parser
inside thellm_chain
of the multi-query retriever with the newly added CustomLineListOutputParser after its initialization.Tests
closes #272