Fix No Feedback Defaults to 0 Score (Negative Feedback) in Snowflake #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidgxue
requested review from
Lee-W,
pankajastro and
sunank200
as code owners
Deploying with
|
| Latest commit: |
38c2877
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a8a63ac2.ask-astro.pages.dev |
| Branch Preview URL: | https://fix-metric-defaulting-to-0.ask-astro.pages.dev |
pankajastro
approved these changes
Feb 23, 2024
pankajkoti
approved these changes
Feb 23, 2024
Lee-W
reviewed
Feb 23, 2024
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Lee-W
approved these changes
Feb 23, 2024
pankajastro
approved these changes
Feb 24, 2024
jlaneve
approved these changes
Feb 29, 2024
sunank200
requested changes
Mar 1, 2024
I can add unit tests for the other PRs. For this PR, there was no unit test for this original file to begin with. In fact, there isn't a single unit test for the entire airflow folder when the previous team worked on this. I can start an initiative for better test coverage to add them, but due to the urgency of this bug fix PR, I don't think it makes sense to write all the unit tests here. |
sunank200
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #291
closes #296 (second issue is used to test, no code change related)
closes #275