Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix] Address URL Formatting Issue Did Not Get Fixed During 0.3.0 #312

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

davidgxue
Copy link
Collaborator

@davidgxue davidgxue commented Mar 6, 2024

Description

  • A previous PR didn't test thoroughly and had a bug so that it did not address the problem.
  • Previous PR: Bugfix: Added changes to update prompt for webapps #306
  • Goal is to have different system prompt for different slack vs webapp client
  • The previous PR was modifying the user's question prompt not system prompt

Related Issue

closes #301
This issue is supposed to be fixed in 0.3.0, but due to inadequate testing during that PR merge, it wasn't caught that the PR didn't address the problem. The bug is re-discovered after 0.3.0 release.

Tests

  1. Sent a request on front end
  2. Got URL embedded into the keywords
image 3. Check Langsmith, metadata has client = webapp image 4. Check langsmith, correct system prompt is used image

Langsmith link

Copy link

cloudflare-pages bot commented Mar 6, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: b580c44
Status: ✅  Deploy successful!
Preview URL: https://692c1a99.ask-astro.pages.dev
Branch Preview URL: https://main-0-3-0-url-formatting-ho.ask-astro.pages.dev

View logs

@davidgxue davidgxue merged commit cc76b19 into main Mar 7, 2024
8 checks passed
@davidgxue davidgxue deleted the main-0.3.0-url-formatting-hotfix branch March 7, 2024 17:17
@davidgxue davidgxue added this to the 0.3.1 milestone Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URL on Website UI Not Correctly Formatted
2 participants