Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code clean up #61

Merged
merged 5 commits into from
Oct 31, 2023
Merged

Code clean up #61

merged 5 commits into from
Oct 31, 2023

Conversation

sunank200
Copy link
Collaborator

@sunank200 sunank200 commented Oct 30, 2023 •
edited

  • Refactor and reduce code complexity
  • Code clean-up
  • Add exception handling
  • Use the Sanic framework for configurations
  • Update doc-strings and typing

closes: #35

@sunank200 sunank200 self-assigned this Oct 30, 2023
@sunank200 sunank200 added the enhancement New feature or request label Oct 30, 2023
@cloudflare-pages
Copy link

cloudflare-pages bot commented Oct 30, 2023 •
edited

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: a04fa83
Status: ✅  Deploy successful!
Preview URL: https://a4d5dc29.ask-astro.pages.dev
Branch Preview URL: https://clean-up.ask-astro.pages.dev

View logs

@sunank200 sunank200 force-pushed the clean-up branch 3 times, most recently from 666ae07 to f856432 Compare October 30, 2023 17:28
@sunank200 sunank200 changed the title Code clean up and exception handling Code clean up Oct 30, 2023
Lee-W
Lee-W approved these changes Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are nitpicks. I think we're good to merge it if we want to.

api/ask_astro/config.py Show resolved Hide resolved
api/ask_astro/rest/controllers/get_request.py Outdated Show resolved Hide resolved
api/ask_astro/rest/controllers/list_recent_requests.py Outdated Show resolved Hide resolved
api/ask_astro/rest/controllers/submit_feedback.py Outdated Show resolved Hide resolved
api/ask_astro/services/feedback.py Outdated Show resolved Hide resolved
api/ask_astro/slack/controllers/feedback/bad.py Outdated Show resolved Hide resolved
api/ask_astro/slack/controllers/feedback/good.py Outdated Show resolved Hide resolved
api/ask_astro/slack/controllers/feedback/good.py Outdated Show resolved Hide resolved
api/ask_astro/slack/controllers/mention.py Outdated Show resolved Hide resolved
api/ask_astro/slack/controllers/mention.py Outdated Show resolved Hide resolved
@sunank200 sunank200 merged commit 9e13016 into main Oct 31, 2023
4 checks passed
@sunank200 sunank200 deleted the clean-up branch October 31, 2023 08:12
pankajastro
pankajastro reviewed Oct 31, 2023
View reviewed changes
.gitignore
Comment on lines +248 to +252
<<<<<<< Updated upstream
/api/gcp.json
=======
api/gcp.json
>>>>>>> Stashed changes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this does not look right PR to fix #71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pankajastro pankajastro pankajastro left review comments

@Lee-W Lee-W Lee-W approved these changes

@jlaneve jlaneve Awaiting requested review from jlaneve jlaneve is a code owner

@pgagnon pgagnon Awaiting requested review from pgagnon

Assignees

@sunank200 sunank200

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code clean up
3 participants
@sunank200 @Lee-W @pankajastro