Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add monitoring for APIs #98

Merged
merged 6 commits into from
Nov 9, 2023
Merged

Add monitoring for APIs #98

merged 6 commits into from
Nov 9, 2023

Conversation

sunank200
Copy link
Collaborator

@sunank200 sunank200 commented Nov 8, 2023

  • Add monitoring for the APIs in sequence.
  • Create notion doc for observability and monitoring.
  • Integrated the monitoring for Open AI.
Screenshot 2023-11-09 at 1 22 34 AM I have tested this with slack integration: Screenshot 2023-11-09 at 5 04 26 PM

closes: #59

Copy link

cloudflare-pages bot commented Nov 8, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8c3a8dc
Status: ✅  Deploy successful!
Preview URL: https://b956f086.ask-astro.pages.dev
Branch Preview URL: https://api-monitoring.ask-astro.pages.dev

View logs

@sunank200 sunank200 changed the title Add monitoring for APIs [WIP] Add monitoring for APIs Nov 8, 2023
@sunank200 sunank200 marked this pull request as ready for review November 8, 2023 19:15
airflow/dags/monitor/external_api.py Outdated Show resolved Hide resolved
airflow/dags/monitor/monitor.py Show resolved Hide resolved
@Lee-W
Copy link
Collaborator

Lee-W commented Nov 9, 2023

As an open source project, I'm not sure we should move the detail steps into a private notion page.

@sunank200
Copy link
Collaborator Author

As an open source project, I'm not sure we should move the detail steps into a private notion page.

The monitoring is internal for Astronomers. I think we should not make this public.

@sunank200 sunank200 requested a review from Lee-W November 9, 2023 06:43
@Lee-W
Copy link
Collaborator

Lee-W commented Nov 9, 2023

As an open source project, I'm not sure we should move the detail steps into a private notion page.

The monitoring is internal for Astronomers. I think we should not make this public.

Yes, agree. But, I might suggest we extract the non-sensitive parts. so that whoever want to build their own ask-astro locally would have a better idea. And of course, we should not publish any data or credentials

@sunank200
Copy link
Collaborator Author

Yes, agree. But, I might suggest we extract the non-sensitive parts. so that whoever want to build their own ask-astro locally would have a better idea. And of course, we should not publish any data or credentials

Sure. Let me put a version in this repo as well

@Lee-W
Copy link
Collaborator

Lee-W commented Nov 9, 2023

Yes, agree. But, I might suggest we extract the non-sensitive parts. so that whoever want to build their own ask-astro locally would have a better idea. And of course, we should not publish any data or credentials

Sure. Let me put a version in this repo as well

not a blocker to this PR though

airflow/dags/monitor/monitor.py Outdated Show resolved Hide resolved
airflow/dags/monitor/monitor.py Outdated Show resolved Hide resolved
airflow/Dockerfile Outdated Show resolved Hide resolved
airflow/dags/monitor/monitor.py Outdated Show resolved Hide resolved
airflow/dags/monitor/monitor.py Show resolved Hide resolved
airflow/dags/monitor/monitor.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@pankajastro pankajastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sunank200 sunank200 merged commit c45487c into main Nov 9, 2023
7 checks passed
@sunank200 sunank200 deleted the api_monitoring branch November 9, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement some observability/monitoring part-2
4 participants