Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent dir walking when searching for a project #106

Merged
merged 1 commit into from Aug 13, 2018

Conversation

andscoop
Copy link
Contributor

@andscoop andscoop commented Aug 8, 2018

This ended up being more re-work than expected as projectRoot was always looking in the curr dir and walking upwards towards usr root dir if config not found. All walking of dirs has been removed in favor of commands that need a config being run directly out of a project root.

  • closes Astro init looks at parent directory #103
  • adds prompt on astro init if user is in non-empty directory
  • removes the upward walking of a dir if user is not in an immediate project dir (defined by existence of config)

@andscoop andscoop requested review from cwurtz and schnie August 8, 2018 18:09
@schnie
Copy link
Member

schnie commented Aug 8, 2018

Makes sense, sounds good to me.

@andscoop andscoop force-pushed the prevent-dir-walking-when-searching-for-project branch from 68cbc4b to 98c2df6 Compare August 13, 2018 19:05
@andscoop andscoop merged commit fae414c into master Aug 13, 2018
@andscoop andscoop deleted the prevent-dir-walking-when-searching-for-project branch August 13, 2018 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Astro init looks at parent directory
2 participants