Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix commands #1491

Merged
merged 1 commit into from
Jan 18, 2024
Merged

fix commands #1491

merged 1 commit into from
Jan 18, 2024

Conversation

sunkickr
Copy link
Contributor

Description

I tested all the commands and fixed the ones that were broken

🎟 Issue(s)

Related #XXX

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (287c2e3) 86.76% compared to head (6d59e56) 86.74%.

Files Patch % Lines
cloud/workspace/workspace_token.go 83.33% 4 Missing ⚠️
cloud/organization/organization_token.go 88.88% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1491      +/-   ##
==========================================
- Coverage   86.76%   86.74%   -0.03%     
==========================================
  Files         115      115              
  Lines       14278    14293      +15     
==========================================
+ Hits        12389    12398       +9     
- Misses       1129     1135       +6     
  Partials      760      760              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sunkickr sunkickr merged commit 3162afc into main Jan 18, 2024
5 of 7 checks passed
@sunkickr sunkickr deleted the fix-commands branch January 18, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants