fix cluster-id in inspect file #1509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunkickr
requested review from
neel-astro,
kushalmalani and
vandyliu
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1509 +/- ##
=======================================
Coverage 85.92% 85.92%
=======================================
Files 112 112
Lines 14838 14840 +2
=======================================
+ Hits 12750 12752 +2
Misses 1252 1252
Partials 836 836 ☔ View full report in Codecov by Sentry. |
vandyliu
reviewed
Jan 30, 2024
| releaseName = notApplicable | ||
| } | ||
| if !deployment.IsDeploymentStandard(*coreDeployment.Type) { |
There was a problem hiding this comment.
can we add/update unit tests for both these cases as well
There was a problem hiding this comment.
We already have unit tests coving each deployment type
There was a problem hiding this comment.
I was wondering why this bug wasn't identified earlier via the unit tests. It might be beneficial for us to consider adding a test case for every bug we resolve, to help prevent any regressions in the future. What do you think?
vandyliu
approved these changes
Feb 1, 2024
kushalmalani
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Made sure that clsuter id is not printing as null. When cluster id does not come from API it is being set to null. It should be set to not applicable.
🎟 Issue(s)
Related #XXX
🧪 Functional Testing
📸 Screenshots
📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft