Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove org short name #1532

Merged
merged 3 commits into from
Feb 7, 2024
Merged

remove org short name #1532

merged 3 commits into from
Feb 7, 2024

Conversation

sunkickr
Copy link
Contributor

@sunkickr sunkickr commented Feb 6, 2024

Description

Org short name has deprecated as input for the API. This PR removes it from the CLI code base

🎟 Issue(s)

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (f1066e0) 85.96% compared to head (6e7961b) 86.06%.
Report is 4 commits behind head on main.

Files Patch % Lines
cloud/organization/organization.go 72.72% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1532      +/-   ##
==========================================
+ Coverage   85.96%   86.06%   +0.09%     
==========================================
  Files         112      112              
  Lines       14962    14887      -75     
==========================================
- Hits        12862    12812      -50     
+ Misses       1265     1253      -12     
+ Partials      835      822      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kushalmalani kushalmalani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this

@sunkickr sunkickr merged commit 907a432 into main Feb 7, 2024
4 of 5 checks passed
@sunkickr sunkickr deleted the remove-org-short-name branch February 7, 2024 04:04
kushalmalani pushed a commit that referenced this pull request Feb 7, 2024
* remove org short name

* fix lint and tests

* fix lint and tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants