fix deployment inspect and list commands #1544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunkickr
requested review from
neel-astro,
kushalmalani and
vandyliu
as code owners
| @@ -246,6 +245,10 @@ func getDeploymentConfig(coreDeploymentPointer *astroplatformcore.Deployment, pl | |||
| if coreDeployment.SchedulerAu != nil { | |||
| deploymentMap["scheduler_au"] = *coreDeployment.SchedulerAu | |||
| } | |||
| if coreDeployment.CloudProvider != nil { | |||
There was a problem hiding this comment.
Do we need to change condition on line 232 for region
There was a problem hiding this comment.
yes I think you are right
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1544 +/- ##
==========================================
+ Coverage 86.06% 86.11% +0.05%
==========================================
Files 112 112
Lines 14916 14919 +3
==========================================
+ Hits 12837 12848 +11
+ Misses 1258 1252 -6
+ Partials 821 819 -2 ☔ View full report in Codecov by Sentry. |
kushalmalani
approved these changes
Feb 13, 2024
kushalmalani
pushed a commit
that referenced
this pull request
Feb 13, 2024
* fix deployment inspect and list commands * fix lint * fix test * fix test * update test * fix lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🎟 Issue(s)
Related #XXX
🧪 Functional Testing
📸 Screenshots
📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft