User and team deployment role management #1553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliotta
requested review from
neel-astro,
kushalmalani,
sunkickr and
vandyliu
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1553 +/- ##
==========================================
+ Coverage 86.28% 86.41% +0.13%
==========================================
Files 113 113
Lines 15221 15668 +447
==========================================
+ Hits 13133 13540 +407
- Misses 1260 1280 +20
- Partials 828 848 +20 ☔ View full report in Codecov by Sentry. |
aliotta
commented
Feb 16, 2024
vandyliu
reviewed
Feb 17, 2024
vandyliu
reviewed
Feb 17, 2024
vandyliu
reviewed
Feb 17, 2024
vandyliu
reviewed
Feb 17, 2024
vandyliu
reviewed
Feb 17, 2024
vandyliu
reviewed
Feb 17, 2024
vandyliu
reviewed
Feb 17, 2024
vandyliu
reviewed
Feb 17, 2024
vandyliu
reviewed
Feb 17, 2024
vandyliu
reviewed
Feb 17, 2024
vandyliu
reviewed
Feb 21, 2024
cmd/cloud/deployment.go
Outdated
| } | ||
| var id string | ||
|
|
||
| // if an email was provided in the args we use it |
vandyliu
reviewed
Feb 21, 2024
cloud/team/team.go
Outdated
| if teams[i].Description != nil { | ||
| teamDescription = *teams[i].Description | ||
| } | ||
| for _, role := range *teams[i].Roles { |
There was a problem hiding this comment.
this scares me a lil if theres a bug on core side, then we might end up with nil pointer exception
vandyliu
reviewed
Feb 21, 2024
| users[i].FullName, | ||
| users[i].Username, | ||
| users[i].Id, | ||
| *users[i].DeploymentRole, |
vandyliu
reviewed
Feb 21, 2024
| } | ||
| resp, err := client.MutateDeploymentUserRoleWithResponse(httpContext.Background(), ctx.Organization, deployment, userID, mutateUserInput) | ||
| if err != nil { | ||
| fmt.Println("error in MutateDeploymentUserRoleWithResponse") |
There was a problem hiding this comment.
should we be printing these?
There was a problem hiding this comment.
I think these are fine as is as we deff want to tell the user an error occurred.
vandyliu
reviewed
Feb 21, 2024
| } | ||
| err = astrocore.NormalizeAPIError(resp.HTTPResponse, resp.Body) | ||
| if err != nil { | ||
| fmt.Println("error in NormalizeAPIError") |
There was a problem hiding this comment.
should we be printing these?
There was a problem hiding this comment.
I think these are fine as is as we deff want to tell the user an error occurred.
vandyliu
reviewed
Feb 21, 2024
cmd/cloud/deployment.go
Outdated
| } | ||
| if updateDeploymentRole == "" { | ||
| // no role was provided so ask the user for it | ||
| updateDeploymentRole = input.Text("Enter a user Deployment role or custom role name to update team: ") |
There was a problem hiding this comment.
Suggested change
| updateDeploymentRole = input.Text("Enter a user Deployment role or custom role name to update team: ") | |
| updateDeploymentRole = input.Text("Enter a Deployment role or custom role name to update team: ") |
kushalmalani
pushed a commit
that referenced
this pull request
Feb 23, 2024
* add cmds for managing deployment user/teams * add unit testing and fix user select bug * add unit test to cmd files * lint * fix default deployment role in add command * fix test name * pr review comments addressed * revert change to flag description for list deployments accross all worksapces * add protections around nil pointers and fix some copy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the ability to CRUD deployment users and deployment teams
🎟 Issue(s)
Related #18925 #18926
🧪 Functional Testing
Ran each method locally to verify it was working as expected
📸 Screenshots
📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft