add org list roles cmd #1554
add org list roles cmd #1554
Conversation
aliotta
requested review from
neel-astro,
kushalmalani,
sunkickr and
vandyliu
as code owners
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1554 +/- ##
==========================================
+ Coverage 86.14% 86.21% +0.07%
==========================================
Files 112 113 +1
Lines 14945 15026 +81
==========================================
+ Hits 12874 12955 +81
Misses 1252 1252
Partials 819 819 ☔ View full report in Codecov by Sentry. |
cloud/role/role.go
Outdated
| if err != nil { | ||
| return nil, nil, err | ||
| } | ||
| defaultRoles = *resp.JSON200.DefaultRoles |
There was a problem hiding this comment.
nit can we do it so we only set this once and after the first ListRolesWithResponse call, we turn includeDefaultRoles to false since we already have em
There was a problem hiding this comment.
actually should we add a flag as to whether to include it or not,
seems kinda annoying to have it always show up if you only care about custom roles
im thinking --include-default-roles should even be default false 🤔
cmd/cloud/organization.go
Outdated
| func newOrganizationRoleRootCmd(out io.Writer) *cobra.Command { | ||
| cmd := &cobra.Command{ | ||
| Use: "role", | ||
| Aliases: []string{"te", "roles"}, |
There was a problem hiding this comment.
team 😂. I just changed it to ro thx
There was a problem hiding this comment.
thanks for the changes
after this is merged, can we get some qa testing on this @shri-astro @sreenusuuda
thank you :D
Description
🎟 Issue(s)
Related #XXX
🧪 Functional Testing
Tested the functionality of the cmd locally
📸 Screenshots
📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft