Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix segmentation fault error #1600

Merged
merged 2 commits into from Mar 14, 2024
Merged

fix segmentation fault error #1600

merged 2 commits into from Mar 14, 2024

Conversation

kushalmalani
Copy link
Contributor

@kushalmalani kushalmalani commented Mar 14, 2024

Description

Describe the purpose of this pull request.

Fixes nil pointer segmentation fault error on deployment variable modify with no deployments in workspace

🎟 Issue(s)

Related #1592

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

image

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.55%. Comparing base (a0d6ed4) to head (55c4be3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1600   +/-   ##
=======================================
  Coverage   86.55%   86.55%           
=======================================
  Files         114      114           
  Lines       15935    15935           
=======================================
  Hits        13792    13792           
  Misses       1288     1288           
  Partials      855      855           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kushalmalani kushalmalani merged commit 5df0221 into main Mar 14, 2024
4 of 5 checks passed
@kushalmalani kushalmalani deleted the fix-panic-error branch March 14, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants