Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

throw error when an api token is bad or invalid #1602

Merged
merged 1 commit into from Mar 16, 2024

Conversation

kushalmalani
Copy link
Contributor

@kushalmalani kushalmalani commented Mar 15, 2024

Description

Describe the purpose of this pull request.

throw error when an api token is bad or invalid

🎟 Issue(s)

Related #XXX

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

export ASTRO_API_TOKEN=test

Screenshot 2024-03-15 at 16 17 40

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 86.57%. Comparing base (5df0221) to head (1c880bb).

Files Patch % Lines
cmd/root.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1602      +/-   ##
==========================================
+ Coverage   86.55%   86.57%   +0.02%     
==========================================
  Files         114      114              
  Lines       15935    15939       +4     
==========================================
+ Hits        13792    13799       +7     
+ Misses       1288     1284       -4     
- Partials      855      856       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kushalmalani kushalmalani merged commit e6f73d7 into main Mar 16, 2024
3 of 5 checks passed
@kushalmalani kushalmalani deleted the throw-bad-api-token-error branch March 16, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants