Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase deployment list limit #1606

Merged
merged 1 commit into from
Mar 28, 2024
Merged

increase deployment list limit #1606

merged 1 commit into from
Mar 28, 2024

Conversation

sunkickr
Copy link
Contributor

@sunkickr sunkickr commented Mar 22, 2024

Description

increase deployment list limit

🎟 Issue(s)

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@sunkickr sunkickr marked this pull request as ready for review March 22, 2024 19:39
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.57%. Comparing base (6b79c3d) to head (83d2639).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1606   +/-   ##
=======================================
  Coverage   86.57%   86.57%           
=======================================
  Files         114      114           
  Lines       15944    15945    +1     
=======================================
+ Hits        13804    13805    +1     
  Misses       1284     1284           
  Partials      856      856           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sunkickr
Copy link
Contributor Author

Screenshot 2024-03-28 at 9 07 30 AM I tested this on a deployment with 200+ deployments and it worked

Copy link
Contributor

@kushalmalani kushalmalani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for testing this

@sunkickr sunkickr merged commit 8e4c4b6 into main Mar 28, 2024
5 of 7 checks passed
@sunkickr sunkickr deleted the fix-deployment-list branch March 28, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants