Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update help message #1609

Merged
merged 1 commit into from
Mar 28, 2024
Merged

update help message #1609

merged 1 commit into from
Mar 28, 2024

Conversation

sunkickr
Copy link
Contributor

Description

update help message to not say -1 but to say 0. In the past we haven't found a way to test cmd.Flags().Changed()

🎟 Issue(s)

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@sunkickr sunkickr marked this pull request as ready for review March 27, 2024 14:32
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.57%. Comparing base (6b79c3d) to head (460dc2d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1609   +/-   ##
=======================================
  Coverage   86.57%   86.57%           
=======================================
  Files         114      114           
  Lines       15944    15946    +2     
=======================================
+ Hits        13804    13806    +2     
  Misses       1284     1284           
  Partials      856      856           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sunkickr
Copy link
Contributor Author

sunkickr commented Mar 27, 2024

tested manually

@sunkickr
Copy link
Contributor Author

sunkickr commented Mar 28, 2024

I added a temporary print statement to show that the PR is working. In the first screenshot the min worker count is not changed so the print statement shows the min count was changed to -1. In the second screenshot the min worker count is 0 so there is no print statement and the min worker count stays 0

Screenshot 2024-03-28 at 10 43 40 AM Screenshot 2024-03-28 at 10 44 12 AM

@sunkickr sunkickr merged commit 382ab25 into main Mar 28, 2024
5 of 7 checks passed
@sunkickr sunkickr deleted the fix-help-min-count branch March 28, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants