-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Token Management Add/Remove/List/Update #1611
Merged
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
b6a8aa2
wip
aliotta 262926d
wip
aliotta cf3924b
wip
aliotta 422ca07
wip
aliotta b89a198
add list org and workspace tokens in deployment cmds
aliotta d15bff6
add workspace token mgmt cmds for managing org tokens in workspaces
aliotta 2d57c4e
remove cyclic import error
aliotta 0de263e
fix existing tests
aliotta b0f7cc8
lint
aliotta 1dbdd11
lint
aliotta 244ad7b
add unit tests for new cloud client methods
aliotta 956fbf7
increase test coverage
aliotta 1da7786
add test coverage for cmds
aliotta e219260
remove token name param from failing test
aliotta 4419792
test fix
aliotta ea2a60a
increase test coverage
aliotta bd24207
increase test coverage
aliotta 8c287ea
more test coverage
aliotta 97ff13c
increase test coverage
aliotta f8fd97d
modify action from create to add
aliotta a31b390
add checks to prevent modification of wrong token types from commands
aliotta 1e23662
add test coverage
aliotta 3ff6018
increase test coverage
aliotta c1ba774
lint
aliotta 4fe2412
improve test coverage
aliotta 124c82a
pr review comments
aliotta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a request header for the API version as well? We do want to get to
v1
so tracking API versions in the client could help with this effort. @vandyliu @fredzhy what do you think?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API version is already handled on core API side so we don't need that info from the clients