Add the Airflow API URL to the deployment inspect output
#1614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our docs currently tell people to get the webserver_url and then manually strip off the org id which is error prone (people forget to do it). Given that the API already has a field for exactly this lets just expose it for users to use!
ashb
requested review from
neel-astro,
kushalmalani,
sunkickr and
vandyliu
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1614 +/- ##
=======================================
Coverage 86.56% 86.56%
=======================================
Files 114 114
Lines 16087 16088 +1
=======================================
+ Hits 13925 13926 +1
Misses 1297 1297
Partials 865 865 ☔ View full report in Codecov by Sentry. |
kushalmalani
reviewed
Apr 7, 2024
ashb
commented
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our docs currently tell people to get the webserver_url and then manually strip off the org id which is error prone (people forget to do it).
Given that the API already has a field for exactly this lets just expose it for users to use!