Fix secret environment variables being updated with empty string #1618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vandyliu
requested review from
neel-astro,
kushalmalani and
sunkickr
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1618 +/- ##
=======================================
Coverage 86.56% 86.56%
=======================================
Files 114 114
Lines 16087 16087
=======================================
Hits 13925 13925
Misses 1297 1297
Partials 865 865 ☔ View full report in Codecov by Sentry. |
| envVars = []astroplatformcore.DeploymentEnvironmentVariableRequest{} | ||
| for i := range deploymentFromFile.Deployment.EnvVars { | ||
| var envVar astroplatformcore.DeploymentEnvironmentVariableRequest | ||
| envVar.IsSecret = deploymentFromFile.Deployment.EnvVars[i].IsSecret | ||
| envVar.Key = deploymentFromFile.Deployment.EnvVars[i].Key | ||
| envVar.Value = &deploymentFromFile.Deployment.EnvVars[i].Value | ||
| // If the action is update, isSecret is true and value is empty, then the value should be left as nil | ||
| if !(action == updateAction && deploymentFromFile.Deployment.EnvVars[i].IsSecret && deploymentFromFile.Deployment.EnvVars[i].Value == "") { |
There was a problem hiding this comment.
Does this mean, i cannot add an empty string for a secret env var? Not an ideal use-case but thinking what if i wanted to?
There was a problem hiding this comment.
yeah that would be a strange case
i don't see why you would want to have a secret variable as ""
anyways if that were the case, i made some updates to the code to allow nil values for no-ops and to allow "" to be updated
kushalmalani
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix secret environment variables being updated. Nil values for existing secret env vars will no longer update the secret variables but keep them with the same value.
🎟 Issue(s)
#1593
🧪 Functional Testing
📸 Screenshots
Updated the secret variable via
./astro deployment update <deploymentId> --deployment-file deployment.yamlSaw on airflow UI that the env var did not get set back to
""📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft