Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Warning message on astro login #1621

Merged
merged 3 commits into from Apr 17, 2024
Merged

Conversation

kushalmalani
Copy link
Contributor

@kushalmalani kushalmalani commented Apr 16, 2024

Description

Describe the purpose of this pull request.

Remove Warning message on astro login when a non astro domain is passed

Screenshot 2024-04-17 at 12 42 16

🎟 Issue(s)

Related #XXX

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.56%. Comparing base (d5f167e) to head (5eef4fd).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1621      +/-   ##
==========================================
- Coverage   86.57%   86.56%   -0.01%     
==========================================
  Files         114      114              
  Lines       16090    16083       -7     
==========================================
- Hits        13930    13923       -7     
  Misses       1296     1296              
  Partials      864      864              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sunkickr
Copy link
Contributor

Lets go with this for now

@kushalmalani kushalmalani merged commit 67a44fe into main Apr 17, 2024
3 checks passed
@kushalmalani kushalmalani deleted the remove-warning-message branch April 17, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants