Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upgrade check input #1628

Merged
merged 3 commits into from
Apr 22, 2024
Merged

Fix upgrade check input #1628

merged 3 commits into from
Apr 22, 2024

Conversation

sunkickr
Copy link
Contributor

@sunkickr sunkickr commented Apr 22, 2024

Description

Make it so you can provide a deployment id with an airflow version, runtime version, or a custom image.

🎟 Issue(s)

Related #XXX

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@sunkickr sunkickr marked this pull request as ready for review April 22, 2024 19:28
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.75%. Comparing base (7adaaca) to head (4505e21).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1628      +/-   ##
==========================================
- Coverage   86.75%   86.75%   -0.01%     
==========================================
  Files         114      114              
  Lines       16667    16661       -6     
==========================================
- Hits        14460    14454       -6     
  Misses       1318     1318              
  Partials      889      889              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kushalmalani
Copy link
Contributor

Should the description be "you can provide" ?

@sunkickr sunkickr merged commit eeffcf9 into main Apr 22, 2024
4 of 5 checks passed
@sunkickr sunkickr deleted the fix-upgrade-check-input branch April 22, 2024 20:00
kushalmalani pushed a commit that referenced this pull request Apr 22, 2024
* remove input checks

* remove input checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants