Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable turning off development mode for existing deployments #1631

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

feluelle
Copy link
Member

@feluelle feluelle commented Apr 24, 2024

Description

We add the --development-mode flag to the deployment update command. Note, that turning on development mode for an existing non-dev deployment is not supported.

🎟 Issue(s)

closes: #1624

πŸ§ͺ Functional Testing

List the functional testing steps to confirm this feature or fix.

❯ ./astro deployment update --development-mode disable
Select a Deployment
 #     DEPLOYMENT NAME        RELEASE NAME               DEPLOYMENT ID                 DAG DEPLOY ENABLED     
 1     test-felix-dev         planetoidal-quark-6380     clvdv13iz02ft01o09r19d36h     true                   
 2     test-felix-non-dev     meteoric-pulsar-4873       clvdv1gqp02ep01nffmtio2cq     true                   

> 1
 NAME               NAMESPACE                  CLUSTER     CLOUD PROVIDER     REGION        DEPLOYMENT ID                 RUNTIME VERSION                     DAG DEPLOY ENABLED     CI-CD ENFORCEMENT     DEPLOYMENT TYPE     
 test-felix-dev     planetoidal-quark-6380     N/A         AWS                us-east-1     clvdv13iz02ft01o09r19d36h     11.1.0 (based on Airflow 2.9.0)     true                   false                 STANDARD            

 Successfully updated Deployment
❯ ./astro deployment update --development-mode enable
Select a Deployment
 #     DEPLOYMENT NAME        RELEASE NAME               DEPLOYMENT ID                 DAG DEPLOY ENABLED     
 1     test-felix-dev         planetoidal-quark-6380     clvdv13iz02ft01o09r19d36h     true                   
 2     test-felix-non-dev     meteoric-pulsar-4873       clvdv1gqp02ep01nffmtio2cq     true                   

> 1
Error: Invalid request: Cannot update an existing non-development Deployment to be a development Deployment

πŸ“Έ Screenshots

Add screenshots to illustrate the validity of these changes.

πŸ“‹ Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 90.47619% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 86.75%. Comparing base (eeffcf9) to head (626612a).

Files Patch % Lines
cloud/deployment/deployment.go 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1631      +/-   ##
==========================================
- Coverage   86.75%   86.75%   -0.01%     
==========================================
  Files         114      114              
  Lines       16661    16676      +15     
==========================================
+ Hits        14454    14467      +13     
- Misses       1318     1320       +2     
  Partials      889      889              

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@feluelle feluelle force-pushed the feature/deployment-update-development-mode branch from 7601ce4 to 626612a Compare April 24, 2024 13:33
@kushalmalani kushalmalani merged commit 32a07a1 into main Apr 29, 2024
3 of 5 checks passed
@kushalmalani kushalmalani deleted the feature/deployment-update-development-mode branch April 29, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable updating deployment dev mode via CLI
2 participants