-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add astro airflow pause #21
Conversation
airflow/docker.go
Outdated
// createProjectFromContext creates project with yaml config as context | ||
func createProjectFromContext(projectName, airflowHome string) (project.APIProject, error) { | ||
// fetchDockerProject creates project with yaml config as context | ||
func fetchDockerProject(projectName, airflowHome string) (project.APIProject, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still not sure about the naming of this func
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, how about just createProject
?
airflow/docker.go
Outdated
|
||
if len(psInfo) > 0 { | ||
// Ensure project is not alreasdy running | ||
for _, info := range psInfo { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prevents a user from running start and having a hard error on an already running project.
airflow/docker.go
Outdated
if len(psInfo) > 0 { | ||
// Ensure project is not alreasdy running | ||
for _, info := range psInfo { | ||
if info["State"][0:2] == "Up" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonder if there's a constant for "Up" in libcompose
. If not, oh well.
airflow/docker.go
Outdated
// createProjectFromContext creates project with yaml config as context | ||
func createProjectFromContext(projectName, airflowHome string) (project.APIProject, error) { | ||
// fetchDockerProject creates project with yaml config as context | ||
func fetchDockerProject(projectName, airflowHome string) (project.APIProject, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, how about just createProject
?
ee95d9b
to
bc76709
Compare
bc76709
to
69bdca6
Compare
@schnie made requested changes This should be good to go |
Closes #18 and #5