add astro airflow pause #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andscoop
commented
Feb 21, 2018
airflow/docker.go
Outdated
| // createProjectFromContext creates project with yaml config as context | ||
| func createProjectFromContext(projectName, airflowHome string) (project.APIProject, error) { | ||
| // fetchDockerProject creates project with yaml config as context | ||
| func fetchDockerProject(projectName, airflowHome string) (project.APIProject, error) { |
There was a problem hiding this comment.
still not sure about the naming of this func
There was a problem hiding this comment.
Yea, how about just createProject?
andscoop
commented
Feb 21, 2018
airflow/docker.go
Outdated
|
|
||
| if len(psInfo) > 0 { | ||
| // Ensure project is not alreasdy running | ||
| for _, info := range psInfo { |
There was a problem hiding this comment.
Prevents a user from running start and having a hard error on an already running project.
schnie
requested changes
Feb 21, 2018
airflow/docker.go
Outdated
| if len(psInfo) > 0 { | ||
| // Ensure project is not alreasdy running | ||
| for _, info := range psInfo { | ||
| if info["State"][0:2] == "Up" { |
There was a problem hiding this comment.
Wonder if there's a constant for "Up" in libcompose. If not, oh well.
airflow/docker.go
Outdated
| // createProjectFromContext creates project with yaml config as context | ||
| func createProjectFromContext(projectName, airflowHome string) (project.APIProject, error) { | ||
| // fetchDockerProject creates project with yaml config as context | ||
| func fetchDockerProject(projectName, airflowHome string) (project.APIProject, error) { |
There was a problem hiding this comment.
Yea, how about just createProject?
andscoop
force-pushed
the
feature/add-astro-airflow-pause
branch
2 times, most recently
from
ee95d9b
to
bc76709
Compare
andscoop
force-pushed
the
feature/add-astro-airflow-pause
branch
from
bc76709
to
69bdca6
Compare
|
@schnie made requested changes This should be good to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18 and #5