Add new astro cli commands to support RBAC in Orbit #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andriisoldatenko
changed the title
andriisoldatenko
force-pushed
the
new-commands-to-support-rbac
branch
from
d081525
to
dbd5e17
Compare
| return nil | ||
| } | ||
| } | ||
| return errors.Errorf("please use one of: %s", strings.Join(validRoles, ", ")) |
There was a problem hiding this comment.
@schnie Please take a look on error message? sounds good?
| @@ -80,6 +80,14 @@ var ( | |||
| RunE: workspaceUserAdd, | |||
| } | |||
|
|
|||
| workspaceUserUpdateCmd = &cobra.Command{ | |||
| Use: "update user role", | |||
schnie
requested changes
May 13, 2019
cmd/workspace.go
Outdated
| ws, err := coalesceWorkspace() | ||
| if err != nil { | ||
| return errors.Wrap(err, "failed to find a valid workspace") | ||
| // fmt.Println("Default workspace id not set, set default workspace id or pass a workspace in via the --workspace-id flag") |
There was a problem hiding this comment.
should we delete this commented out line?
| return nil | ||
| } | ||
| } | ||
| return errors.Errorf("please use one of: %s", strings.Join(validRoles, ", ")) |
| @@ -80,6 +80,14 @@ var ( | |||
| RunE: workspaceUserAdd, | |||
| } | |||
|
|
|||
| workspaceUserUpdateCmd = &cobra.Command{ | |||
| Use: "update user role", | |||
cmd/workspace.go
Outdated
| workspaceUserUpdateCmd = &cobra.Command{ | ||
| Use: "update user role", | ||
| Short: "Update a user to a workspace", | ||
| Long: "Update a user to a workspace", |
There was a problem hiding this comment.
Maybe "Update a user's role for a workspace"
cmd/workspace.go
Outdated
| workspaceUserListCmd = &cobra.Command{ | ||
| Use: "list", | ||
| Short: "Print list of user roles", | ||
| Long: "Print list of user roles", |
There was a problem hiding this comment.
How about "List users in a workspace"?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #212