Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update authConfig schema #255

Merged
merged 1 commit into from Jul 16, 2019
Merged

update authConfig schema #255

merged 1 commit into from Jul 16, 2019

Conversation

andriisoldatenko
Copy link
Contributor

@andriisoldatenko andriisoldatenko commented Jul 16, 2019 •
edited

fix #254

@andriisoldatenko andriisoldatenko self-assigned this Jul 16, 2019
@andriisoldatenko andriisoldatenko added this to the v0.10 milestone Jul 16, 2019
ashb
ashb reviewed Jul 16, 2019
View reviewed changes
Copy link
Contributor

@ashb ashb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I didn't realise the cli used this too. Maybe I should leave the old properties so that the CLI will work for all 0.9

@andriisoldatenko
Copy link
Contributor Author

hm.... 🤔
cc @schnie

@schnie
Copy link
Member

schnie commented Jul 16, 2019

We do release a matching version of everything so we could make the switch. Maybe at 1.0 we start supporting backward compatibility. I just hate to start accruing backward compatible code before we have something we feel is even stable to begin with.

@andriisoldatenko
Copy link
Contributor Author

cc @dimberman

@dimberman dimberman self-requested a review July 16, 2019 21:25
@schnie schnie merged commit c6f06f0 into master Jul 16, 2019
@schnie schnie deleted the update-authconfig-schema branch July 16, 2019 21:54
ashb pushed a commit that referenced this pull request Jul 17, 2019
@andriisoldatenko @ashb
update authConfig schema (#255)
83284e2 
(cherry picked from commit c6f06f0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashb ashb ashb left review comments

@dimberman dimberman dimberman approved these changes

@schnie schnie Awaiting requested review from schnie schnie is a code owner

Assignees

@andriisoldatenko andriisoldatenko

Labels
None yet
Projects
None yet
Milestone
v0.10
Development

Successfully merging this pull request may close these issues.

Update to use new AuthConfig/AuthProvider schema
4 participants
@andriisoldatenko @schnie @ashb @dimberman