Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ability to manually set releaseName during create deployment #327

Merged
merged 3 commits into from May 6, 2020

Conversation

andriisoldatenko
Copy link
Contributor

fix astronomer/issues#548

related PR https://github.com/astronomer/houston-api/pull/266

@schnie
Copy link
Member

schnie commented Apr 24, 2020

@andriisoldatenko this is going to be a platform level setting - if you can set this releaseName or not. It's going to come down in the appConfig query now. Do we need to adjust this to deal with if this functionality is enabled or not?

@andriisoldatenko
Copy link
Contributor Author

@schnie good catch, i'll fix my pr according latest Sam's changes in houston-api.

@andriisoldatenko andriisoldatenko requested a review from ashb May 5, 2020 23:49
@andriisoldatenko
Copy link
Contributor Author

@schnie PTAL

@andriisoldatenko
Copy link
Contributor Author

practically LGTM:

astro deployment create new-deployment-name --executor=celery --release-name=hello-from-astro-cli
 NAME                    DEPLOYMENT NAME          ASTRO              DEPLOYMENT ID                 TAG
 new-deployment-name     hello-from-astro-cli     0.13.0-alpha.2     ck9ukag1a01w70j740sibbxkp     %!s(MISSING)
 Successfully created deployment with Celery executor. Deployment can be accessed at the following URLs
 Airflow Dashboard: https://deployments.local.astronomer-development.com/hello-from-astro-cli/airflow
 Flower Dashboard: https://deployments.local.astronomer-development.com/hello-from-astro-cli/flower
2:47
NAME                                              READY   STATUS     RESTARTS   AGE
hello-from-astro-cli-flower-769559c7b5-2qw95      1/1     Running    0          54s
hello-from-astro-cli-pgbouncer-5cdf8dc6f4-dql8p   2/2     Running    0          54s
hello-from-astro-cli-redis-0                      1/1     Running    0          54s
hello-from-astro-cli-scheduler-77b69646d6-7lmds   0/2     Init:0/1   0          54s
hello-from-astro-cli-statsd-f4579cdfb-l4jrn       1/1     Running    0          54s
hello-from-astro-cli-webserver-6d5867df75-sws5n   0/1     Init:0/1   0          54s
hello-from-astro-cli-worker-676c4f97b9-fxkfc      0/1     Init:0/1   0          54s
2:48
astro deployment create new-deployment-name1 --executor=celery --release-name=hello_test_fail
Error: Release name not formatted correctly.
exit status 1
LGTM

@schnie schnie merged commit bb4da75 into master May 6, 2020
@schnie schnie deleted the feature/manual-releasenames branch May 6, 2020 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants