Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing deployment service account #329

Merged
merged 2 commits into from May 5, 2020

Conversation

andriisoldatenko
Copy link
Contributor

deployment sa get
Error: required flag(s) "deployment-id" not set
Usage:
  astro deployment service-account get [flags]

Examples:

  # Get deployment service-account
  $ astro deployment service-account get <service-account-id> --deployment-id=<deployment-id>

  # or using deployment-id
  $ astro deployment service-account get --deployment-id=<deployment-id>


Flags:
  -d, --deployment-id string   [ID]
  -h, --help                   help for get

cc @paolaperaza

@andriisoldatenko
Copy link
Contributor Author

before this change:

astro deployment service-account get -w ck8zxlr17005a0r976r5nkcc6
Error: A required argument was not sent: serviceAccountUuid or entityUuid
exit status 1

after

astro deployment service-account get -d ck8zxlr17005a0r976r5nkcc6
 NAME     CATEGORY     ID                            APIKEY
 test                  ck9szggpe08rc0n642zm7kjy0     30da15**************************

@paolaperaza
Copy link
Contributor

Thanks for this, @andriisoldatenko ! So, was the astro deployment service-account get -d command essentially broken prior? Is there any way a customer would've been able to grab deployment-level SAs prior to this change, or is it just a syntax correction?

cc: @vishwas-astro This is something we caught via Slack yesterday (https://astronomerteam.slack.com/archives/CLRKTKHGU/p1588628044301800?thread_ts=1588627261.297400&cid=CLRKTKHGU). Will create a GH issue for it once Andrii confirms what the original problem was

@vishwas-astro
Copy link

@paolaperaza , thanks. Please create a GH issue and add it to 0.14 board.

@schnie schnie merged commit fa195c8 into master May 5, 2020
@schnie schnie deleted the hotfix/missing-deployment-id-flag branch May 5, 2020 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants