-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve astro-cli UX when user trying to work locally without access houston #347
Conversation
Codecov Report
@@ Coverage Diff @@
## master #347 +/- ##
==========================================
+ Coverage 51.03% 51.46% +0.42%
==========================================
Files 31 31
Lines 2312 2322 +10
==========================================
+ Hits 1180 1195 +15
+ Misses 1054 1050 -4
+ Partials 78 77 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉🛳
90f83ad
to
d16b6c8
Compare
LGTM, I assume the git commit only shows when running a local build right? Could that come first? Just seems out of order to have the git version sandwiched between the two different Astro-versions. |
@schnie wdyt? (inspired by kubectl)
|
Confirming the changes here:
After authenticating:
|
…houston (#347) * Improve astro-cli UX when user trying to work locally without access to houston * join astro cli version and hash commit * fix unit tests
fix https://github.com/astronomer/issues/issues/1516
should work without access to houston server:
astro dev init
astro dev start
astro dev kill
astro dev logs
astro dev stop
astro dev ps
astro dev run
and astro version should print correct message instead of crashing:
cc @schnie @paolaperaza