New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add airflow 2.0 min requirements #395
Conversation
Codecov Report
@@ Coverage Diff @@
## main #395 +/- ##
=======================================
Coverage 54.51% 54.51%
=======================================
Files 32 32
Lines 2313 2335 +22
=======================================
+ Hits 1261 1273 +12
- Misses 963 968 +5
- Partials 89 94 +5
Continue to review full report at Codecov.
|
settings/settings.go
Outdated
@@ -32,7 +32,7 @@ var ( | |||
settings Config | |||
|
|||
// Version 2.0.0 | |||
newAirflowVersion uint64 = 2 | |||
NewAirflowVersion uint64 = 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New - is slightly confuse me, cause it's de facto constructor of objects in golang.
can we rename to something more readable rather than just NewAirflowVersion
?
AirflowVersionSecond
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I didn't know what we should call it because it's a special case. AirflowVersionSecond
or AirflowVersionTwo
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep but i. prefer to name explain value, since it's airflow 2.0.0 specific.
AirflowVersionTwo
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to AirflowVersionTwo
* Add airflow 2.0 min requirements * Fix AirflowVersionTwo variable name
Description
Make sure that an Airflow deployment is using version
1.10.14
before allowing the upgrade to2.0.x
馃師 Issue(s)
Resolves astronomer/issues#2289
馃И Functional Testing
It's possible to test this change locally.
1.10.14
. (I was testing with1.10.12
)AirflowRelease
table. If not, manually add it (you can copy and existing deployment and change the version number for testing purposes)1.10.14
and attempt to upgrade again. You should now see the success message.馃摳 Screenshots
馃搵 Checklist
make test
before taking out of draft