Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link in airflow.settings.yaml file #411

Merged
merged 2 commits into from
May 18, 2021

Conversation

paolaperaza
Copy link
Contributor

@paolaperaza paolaperaza commented May 13, 2021

Description

This is a hotfix PR does a few small things:

  1. Fixes the broken link in the airflow_settings.yaml file that is automatically generated when a user runs $ astro dev init via the Astronomer CLI.
  2. Removes the ## This feature is in Beta comment (that has been there for 2+ years...)
  3. Adds improved copy that better informs the user on what this file should be used for

Old link: https://github.com/astronomer/docs/blob/main/v0.10/cli-airflow-configuration.md
New Link: https://www.astronomer.io/docs/cloud/stable/develop/customize-image#configure-airflowsettingsyaml

馃師 Issue(s)

Resolves https://github.com/astronomer/issues/issues/2850

馃搵 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Added/updated applicable tests
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@vishwas-astro @andriisoldatenko This felt like an easy fix so I gave it a shot 馃槉 Let me know if I missed anything or if you have feedback on the copy here.

@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

Merging #411 (1bcc9b1) into main (9ab5114) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #411   +/-   ##
=======================================
  Coverage   56.52%   56.52%           
=======================================
  Files          32       32           
  Lines        2406     2406           
=======================================
  Hits         1360     1360           
- Misses        945      946    +1     
+ Partials      101      100    -1     
Impacted Files Coverage 螖
docker/docker.go 27.84% <0.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 9ab5114...1bcc9b1. Read the comment docs.

airflow/include/settingsyml.go Outdated Show resolved Hide resolved
airflow/include/settingsyml.go Show resolved Hide resolved
Copy link
Contributor

@adam2k adam2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2021-05-17 at 2 47 57 PM

LGTM! 馃帀

@paolaperaza paolaperaza merged commit 880a532 into main May 18, 2021
@ashb ashb deleted the paola-fix-broken-link-airflow_settings.yaml branch December 9, 2021 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants