Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add example dag on project init #46

Merged
merged 2 commits into from Mar 9, 2018
Merged

Conversation

andscoop
Copy link
Contributor

@andscoop andscoop commented Mar 8, 2018

@andscoop andscoop requested a review from schnie March 8, 2018 22:54
@schnie
Copy link
Member

schnie commented Mar 9, 2018

@andscoop what you think about breaking these files out into their own?

@andscoop
Copy link
Contributor Author

andscoop commented Mar 9, 2018

We can - I thought above moving them to include/

@schnie
Copy link
Member

schnie commented Mar 9, 2018

Sounds good

@andscoop
Copy link
Contributor Author

andscoop commented Mar 9, 2018

@schnie I broke the files out into /airflow/include. I originally planned to put them into /include/ but this would have potentially conflicted with the /include/ dir we create on astro airflow init if a developer is working from root astro directory.

@schnie schnie merged commit 58c9b47 into master Mar 9, 2018
@andscoop andscoop deleted the feature/4_init_creates_example_dag branch March 9, 2018 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

init command should create a “hello world” DAG in CLI
2 participants