Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed image parsing logic #470

Merged
merged 2 commits into from
Jan 3, 2022
Merged

Fixed image parsing logic #470

merged 2 commits into from
Jan 3, 2022

Conversation

neel-astro
Copy link
Contributor

Description

Changes:

  • Fixed logic with parsing image name from Dockerfile to fix issues with ports being in hostname, panic when no tag is present.

馃師 Issue(s)

Related astronomer/issues#926
Related astronomer/issues#3473
Related astronomer/issues#3605

馃И Functional Testing

List the functional testing steps to confirm this feature or fix.

馃摳 Screenshots

Add screenshots to illustrate the validity of these changes.

馃搵 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Added/updated applicable tests
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

docker/parse.go Outdated
if ok {
tag = parsedTag.Tag()
} else {
tag = "latest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can avoid else here:

tag = "latest"
if ok {
     tag = parsedTag.Tag()
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, updated 馃憤

@codecov
Copy link

codecov bot commented Dec 28, 2021

Codecov Report

Merging #470 (b65dd0e) into main (4ad198a) will increase coverage by 0.05%.
The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #470      +/-   ##
==========================================
+ Coverage   64.59%   64.65%   +0.05%     
==========================================
  Files          42       42              
  Lines        3548     3559      +11     
==========================================
+ Hits         2292     2301       +9     
- Misses       1093     1094       +1     
- Partials      163      164       +1     
Impacted Files Coverage 螖
docker/parse.go 85.45% <84.61%> (-0.91%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 4ad198a...b65dd0e. Read the comment docs.

@neel-astro neel-astro merged commit f836472 into main Jan 3, 2022
neel-astro added a commit that referenced this pull request Jan 10, 2022
* fixed image parsing logic

* code review changes
@neel-astro neel-astro deleted the fix/image-parser branch February 9, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants