Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added config option to specify container names #478

Merged
merged 4 commits into from
Jan 7, 2022

Conversation

neel-astro
Copy link
Contributor

@neel-astro neel-astro commented Jan 4, 2022

Description

Changes:

  • Added container_name as a config under scheduler, webserver & triggerer
  • Set the container_name in docker compose and pod-config file from the values obtained from config file, default values for schedule, webserver & triggerer are kept as "scheduler", "webserver" & "triggerer" respectively.
  • Some automated lint changes done from pre-commit

馃師 Issue(s)

Related astronomer/issues#3787

馃И Functional Testing

List the functional testing steps to confirm this feature or fix.

馃摳 Screenshots

Add screenshots to illustrate the validity of these changes.

馃搵 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Added/updated applicable tests
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@codecov
Copy link

codecov bot commented Jan 4, 2022

Codecov Report

Merging #478 (4e5f4b5) into main (5713eb3) will increase coverage by 0.01%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #478      +/-   ##
==========================================
+ Coverage   66.25%   66.27%   +0.01%     
==========================================
  Files          42       42              
  Lines        3642     3644       +2     
==========================================
+ Hits         2413     2415       +2     
  Misses       1056     1056              
  Partials      173      173              
Impacted Files Coverage 螖
config/config.go 46.37% <酶> (酶)
config/types.go 35.71% <酶> (酶)
airflow/docker.go 48.42% <50.00%> (-0.28%) 猬囷笍
cmd/airflow.go 67.91% <66.66%> (酶)
airflow/container.go 48.35% <100.00%> (+1.76%) 猬嗭笍
airflow/podman.go 77.11% <100.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 5713eb3...4e5f4b5. Read the comment docs.

@neel-astro neel-astro marked this pull request as ready for review January 5, 2022 07:48
@neel-astro neel-astro force-pushed the feature/consistent-container-name branch from 40fcfd2 to 0f54e12 Compare January 5, 2022 09:29
Copy link
Contributor

@bote795 bote795 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@neel-astro neel-astro merged commit 8f9f628 into main Jan 7, 2022
neel-astro added a commit that referenced this pull request Jan 10, 2022
* Merge branch 'main' into feature/consistent-container-name

* removed hardcoded component name

* fixed failing test case
@neel-astro neel-astro deleted the feature/consistent-container-name branch February 9, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants