Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed volume and postgres container naming convention in docker compose #482

Merged
merged 1 commit into from
Jan 20, 2022

Conversation

neel-astro
Copy link
Contributor

Description

Changes:

  • Fixed volume & postgres container naming for docker and pod naming in case of podman for cases when project directory doesn't contain lowercase alphabet or number as prefix, i.e. starts with . or any other special characters

🎟 Issue(s)

Related astronomer/issues#3749

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Added/updated applicable tests
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #482 (753493a) into main (301ea78) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #482   +/-   ##
=======================================
  Coverage   66.27%   66.27%           
=======================================
  Files          42       42           
  Lines        3644     3644           
=======================================
  Hits         2415     2415           
  Misses       1056     1056           
  Partials      173      173           
Impacted Files Coverage Δ
airflow/container.go 48.35% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 301ea78...753493a. Read the comment docs.

Copy link
Contributor

@bote795 bote795 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@neel-astro neel-astro merged commit 70607c4 into main Jan 20, 2022
@neel-astro neel-astro deleted the fix/volume-naming-convention branch February 9, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants